Skip to content

[release-4.3] Bug 1798170: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 19, 2020
Merged

[release-4.3] Bug 1798170: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml #1438

openshift-merge-robot merged 1 commit into from
Feb 19, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 4, 2020

This is an automated cherry-pick of #1419

/assign hardys

baremetal: Remove .template from path in dhcp-dhclient-conf.yaml
1319743 
This appears to get written out as /etc/dhcp/dhclient.conf.template
with no subsequent render-config templating to create the actual
/etc/dhcp/dhclient.conf - modifying the path results in the file
being correctly written.
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 4, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1796148, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1796148 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1796148: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2020
@hardys
Copy link

hardys commented Feb 4, 2020

/retitle [release-4.3] Bug 1798170: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1796148: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml [release-4.3] Bug 1798170: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1798170, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected dependent Bugzilla bug 1796148 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1798170: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Feb 4, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2020

@hardys: This pull request references Bugzilla bug 1798170, which is invalid:

  • expected dependent Bugzilla bug 1796148 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member

runcom commented Feb 5, 2020

/skip
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@russellb
Copy link
Contributor

russellb commented Feb 12, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2020

@russellb: This pull request references Bugzilla bug 1798170, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 12, 2020
@sinnykumari
Copy link
Contributor

sinnykumari commented Feb 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, runcom, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/hold

For this to be correct first we should merge the backport PR that removes prepend domain-name-servers {{{{ .NonVirtualIP }}}};

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/hold cancel

Ok. I checked and release-4.3 already does not have the runtime rendering line. So no need to hold.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 1319743 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 28eccc5 into openshift:release-4.3 Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1798170 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1798170: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@hardys hardys

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@openshift-cherrypick-robot @openshift-ci-robot @hardys @runcom @russellb @sinnykumari @celebdor @openshift-bot @bparees @openshift-merge-robot